Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply role "install-docker" to all of jobs #575

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Conversation

kiwik
Copy link
Contributor

@kiwik kiwik commented Jun 28, 2019

Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308

Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308
@kiwik kiwik added this to In Progress in OpenLab Status Board via automation Jun 28, 2019
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 28, 2019

Build succeeded.

Copy link
Contributor

@liusheng liusheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

OpenLab Status Board automation moved this from In Progress to Reviewed Jun 28, 2019
@ZhengZhenyu
Copy link
Contributor

why not get rid of install-docker-ce role in this patch directly?

@kiwik
Copy link
Contributor Author

kiwik commented Jun 28, 2019

@ZhengZhenyu will remove role install-docker-ce when all of related job builds are OK

@ZhengZhenyu ZhengZhenyu merged commit 9b1d078 into master Jun 28, 2019
OpenLab Status Board automation moved this from Reviewed to Done Jun 28, 2019
@huangtianhua huangtianhua deleted the apply-docker-role branch June 28, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4 participants