Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply role install-docker-ce for all of OpenLab jobs #308

Closed
kiwik opened this issue Jun 26, 2019 · 0 comments · Fixed by theopenlab/openlab-zuul-jobs#575
Closed

Apply role install-docker-ce for all of OpenLab jobs #308

kiwik opened this issue Jun 26, 2019 · 0 comments · Fixed by theopenlab/openlab-zuul-jobs#575
Assignees
@kiwik
Labels
bug Something isn't working
Projects
OpenLab Status Board

Comments

@kiwik
Copy link
Contributor

kiwik commented Jun 26, 2019

Thank you for reporting bug!

Describe the bug

  1. There are several different ways to install docker in OpenLab jobs, we should use role install-docker-ce for all of them to reduce the maintaince workload.
  2. Some job tags are - Application:Docker@latest-release in jobs.yaml, lastest-release always cause some confusion to OpenLab user, because the version is changed with time gone. We should pin the docker version in these jobs.

Related Job information

If the bug is related a CI job, put the job information below:

  • job name:
    • docker-machine-v0.16.1-functional-devstack-mitaka
    • docker-machine-v0.16.1-functional-devstack-newton
    • docker-machine-v0.16.1-functional-devstack-ocata
    • docker-machine-v0.16.1-functional-devstack-pike
    • docker-machine-v0.16.1-functional-devstack-queens
    • docker-machine-v0.16.1-functional-devstack-rocky
    • docker-machine-v0.16.1-functional-devstack-stein
    • spark-integration-test-kubeadm-k8s-v1.14.0
    • kind-integration-test-arm64
    • helm-integration-test-kubeadm-k8s-v1.14.0
  • role name:
    • install-k8s
    • config-docker-machine
    • create-multinodes-k8s-cluster-with-kubeadm
    • create-single-k8s-cluster-with-kubeadm
  • job build log link: NA
  • error log piece: NA

Steps to reproduce the issue

Describe how to reproduce the issue:
Check job log

Additional context

Add any other context about the problem here.
@kiwik kiwik added the bug Something isn't working label Jun 26, 2019
@kiwik kiwik self-assigned this Jun 26, 2019
@kiwik kiwik added this to To Do in OpenLab Status Board via automation Jun 26, 2019
@kiwik kiwik moved this from To Do to In Progress in OpenLab Status Board Jun 26, 2019
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 26, 2019
@kiwik
Add new role "install-docker"
bc639a3 
The new role "install-docker" install docker-ce by using get.docker.com
script, it support multiple OS and arch, and keep consistent docker-ce
version, mark role "install-docker-ce" as deprecated, and apply new role
in all of docker-machine jobs. Update tag of docker-machine job from
latest-release to 18.06 in order to avoid confusions.

Related-Bug: theopenlab/openlab#308
@kiwik kiwik mentioned this issue Jun 26, 2019
Merged
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 26, 2019
@kiwik
Add new role "install-docker"
1b02d45 
The new role "install-docker" install docker-ce by using get.docker.com
script, it support multiple OS and arch, and keep consistent docker-ce
version, mark role "install-docker-ce" as deprecated, and apply new role
in all of docker-machine jobs. Update tag of docker-machine job from
latest-release to 18.06 in order to avoid confusions.

Related-Bug: theopenlab/openlab#308
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 26, 2019
@kiwik
Add new role "install-docker"
ea55344 
The new role "install-docker" install docker-ce by using get.docker.com
script, it support multiple OS and arch, and keep consistent docker-ce
version, mark role "install-docker-ce" as deprecated, and apply new role
in all of docker-machine jobs. Update tag of docker-machine job from
latest-release to 18.06 in order to avoid confusions.

Related-Bug: theopenlab/openlab#308
OpenLab Status Board automation moved this from In Progress to Done Jun 27, 2019
OpenLab Status Board automation moved this from Done to In Progress Jun 27, 2019
huangtianhua pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 28, 2019
@kiwik @huangtianhua
Add new role "install-docker" (#571)
5d90f8f 
The new role "install-docker" install docker-ce by using get.docker.com
script, it support multiple OS and arch, and keep consistent docker-ce
version, mark role "install-docker-ce" as deprecated, and apply new role
in all of docker-machine jobs. Update tag of docker-machine job from
latest-release to 18.06 in order to avoid confusions.

Related-Bug: theopenlab/openlab#308
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 28, 2019
@kiwik
Apply role "install-docker" to all of jobs
06d39c2 
Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 28, 2019
@kiwik
Apply role "install-docker" to all of jobs
d0c6074 
Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308
@kiwik kiwik mentioned this issue Jun 28, 2019
Merged
OpenLab Status Board automation moved this from In Progress to Done Jun 28, 2019
ZhengZhenyu pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 28, 2019
@kiwik @ZhengZhenyu
Apply role "install-docker" to all of jobs (#575)
9b1d078 
Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 29, 2019
@kiwik
Fix spark-integration-test-minikube-k8s issue
882fbef 
1. Remove deprecated role "install-docker-ce"
2. Apply role "install-openjdk" instead of installing OpenJDK in run.yaml
3. Add option "--r" for command "make-distribution.sh" in minikube job
   to avoid following docker build error because R code can't be found
   in docker file.

Related-Bug: theopenlab/openlab#310
Related-Bug: theopenlab/openlab#308
@kiwik kiwik mentioned this issue Jun 29, 2019
Merged
huangtianhua pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jun 29, 2019
@kiwik @huangtianhua
Fix spark-integration-test-minikube-k8s issue (#578)
fe47b0a 
1. Remove deprecated role "install-docker-ce"
2. Apply role "install-openjdk" instead of installing OpenJDK in run.yaml
3. Add option "--r" for command "make-distribution.sh" in minikube job
   to avoid following docker build error because R code can't be found
   in docker file.

Related-Bug: theopenlab/openlab#310
Related-Bug: theopenlab/openlab#308
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 1, 2019
@kiwik
Fix install-docker role
d066fcc 
systemctl is not available on Ubuntu 14.04, so using
"service docker restart" as a workaround.

Related-Bug: theopenlab/openlab#308
@kiwik kiwik mentioned this issue Jul 1, 2019
Merged
kiwik added a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 1, 2019
@kiwik
Fix install-docker role
b1ad923 
1. systemctl is not available on Ubuntu 14.04, so using
   "service docker restart" as a workaround.
2. change option "--r" position in spark-inegration-test-minikube-k8s
   job to avoid "--r" is bypassed to mvn.

Related-Bug: theopenlab/openlab#308
Related-Bug: theopenlab/openlab#310
liusheng pushed a commit to theopenlab/openlab-zuul-jobs that referenced this issue Jul 4, 2019
@kiwik @liusheng
Fix install-docker role (#580)
8810da5 
* Fix install-docker role

1. systemctl is not available on Ubuntu 14.04, so using
   "service docker restart" as a workaround.
2. change option "--r" position in spark-inegration-test-minikube-k8s
   job to avoid "--r" is bypassed to mvn.

Related-Bug: theopenlab/openlab#308
Related-Bug: theopenlab/openlab#310

* Do not install docker when config docker machine

Co-authored-by: liu-sheng <liusheng2048@gmail.com>

* Do not need to clean iptables rules when installing docker

I did not found any docs say that need to clean iptables when installing
docker, only found in[1]. So I may prefer we do not clean iptables rules
unless we really need, and that should be done in where use docker that
in docker installation.

[1] https://github.com/kubernetes/cloud-provider-openstack/blob/master/devstack/plugin.sh#L98-L107

* Change the order of roles in docker-machine job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiwik kiwik

Labels
bug Something isn't working
Projects
OpenLab Status Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply role "install-docker" to all of jobs theopenlab/openlab-zuul-jobs
2 participants
@kiwik @click2cloud-jyoti