Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: increase parallelization of CI jobs #1154

Merged
merged 6 commits into from
Sep 22, 2022
Merged

ci: increase parallelization of CI jobs #1154

merged 6 commits into from
Sep 22, 2022

Conversation

gunar
Copy link
Contributor

@gunar gunar commented Sep 20, 2022 •
edited
Loading

Removed some unnecesary CI dependencies so that things can run in parallel:

  • Pulumi Preview doesn't depend on API nor Integration Tests
  • Pizzas don't depend on tests, only on the React build
  • Hasura Change Summary doesn't depend on anything
  • Splits up testing and building the React app, to increase parallelization
  • Splits up building the React app and building Storybook (because staging/production/pulumi doesn't need storybook)

Also:

  • Disable tests on merge given it's all been tested in a PR before merging
  • Caches react builds to prevent rebuilding (ie if you add a new commit to an existing PR, and editor.planx.uk didn't change, then CI is prevented from re-building exactly the same assets)
  • Same as above but for Storybook

Diff

Before

image

After

image

@gunar gunar self-assigned this Sep 20, 2022
@gunar gunar changed the title g/build and test ci: split up testing and building react steps Sep 20, 2022
@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited
Loading

Removed vultr server and associated DNS entries

@gunar gunar force-pushed the g/build-and-test branch 4 times, most recently from 6f9a823 to 9e858bb Compare September 20, 2022 20:34
@gunar gunar mentioned this pull request Sep 20, 2022
Closed
@gunar gunar changed the title ci: split up testing and building react steps ci: increase parallelization of CI jobs Sep 20, 2022
@gunar gunar requested a review from a team September 20, 2022 21:56
@gunar
Copy link
Contributor Author

gunar commented Sep 20, 2022

Spike: Identify ways to speed up our CD/CI pipeline

@gunar gunar mentioned this pull request Sep 21, 2022
Merged
@gunar
Copy link
Contributor Author

gunar commented Sep 21, 2022

I've squashed some commits for readability.

DafyddLlyr
DafyddLlyr approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice thanks - solid improvement👌

@gunar gunar merged commit 3029238 into main Sep 22, 2022
@gunar gunar deleted the g/build-and-test branch September 22, 2022 16:54
gunar added a commit that referenced this pull request Sep 23, 2022
@gunar
Merge remote-tracking branch 'origin/main' into g/skip-ci
fa7be95 
* origin/main:
  chore: remove .env files and access secrets from remote S3 bucket (#1137)
  ci: increase parallelization of CI jobs (#1154)
  fix: update wording of Article 4 planning constraints (#1160)
  infra: increase budget alert threshold (#1161)
  fix: Set session immediately after reconciliation (#1157)
@DafyddLlyr DafyddLlyr mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees

@gunar gunar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunar @DafyddLlyr