Hyphenated prereleases. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check can be tightened down later if we want to implement only (/sigh) the *current* v1.0.0 SemVer spec.
|
I hadn't even thought about that. I'll have it here in a moment. |
This produces output results that now properly conform to the most modern version of the SemVer spec w.r.t. prerelease versions.
|
Thank you very much. I've just pushed v0.3.0 to PGXN; it should show up on mirrors shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for an optional hyphen before a prerelease name.
This is far from ideal, but since the v1.0.0 spec has (at different times) declared both that prereleases must begin with an letter and that they must begin with a hyphen, it seems prudent to do some form of transitional change. Then again, backwards compatibility may not be a concern for this early version, so we may wish to skip the transition altogether.
In any event, this change implements the 80% case between both versions of the spec: most prerelease versions already begin with a letter, whether they contain the hyphen or not.