Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up/unify the Darwin-based targets #242

Closed
kirb opened this issue Mar 19, 2017 · 2 comments
Closed

Clean up/unify the Darwin-based targets #242

kirb opened this issue Mar 19, 2017 · 2 comments
Assignees

Comments

@kirb
Copy link
Member

kirb commented Mar 19, 2017

We have 4 different versions of iphone.mk, and holy crap, 7 different Darwin-based targets supported on macOS. There’s a high amount of code duplication and inconsistency, such as in #209.

Almost all of each target makefile is exactly the same, especially on macOS, just with the particular target name changed. And for pretty much every instance of xcrun -sdk iphoneos we can just use xcrun, because none of these binaries are SDK-specific any more. SDK scanning might need a cleanup. Non-Xcode cross-compile toolchain logic definitely needs a cleanup.

@sbingner
Copy link
Contributor

sbingner commented Apr 2, 2017

I fixed the SDK sort order issue for latest by using:
_IOS_SDKS := $(shell echo $(patsubst $(_XCODE_SDK_DIR)/iPhoneOS%.sdk,%'\n',$(wildcard $(_XCODE_SDK_DIR)/iPhoneOS*.sdk))'\n'$(patsubst $(THEOS_SDKS_PATH)/iPhoneOS%.sdk,%'\n',$(wildcard $(THEOS_SDKS_PATH)/iPhoneOS*.sdk)) | sort -n | paste -s -d" " - )

in makefiles/targets/Darwin/iphone.mk

kirb added a commit that referenced this issue Jan 28, 2018
Todo: test macosx, watch, tv + simulators; also clean up iphone for the other
platforms. Ref: #242
@kirb
Copy link
Member Author

kirb commented May 8, 2018

Done in Theos 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants