-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to add/update offline docs #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this code looks good. The workflow will not work though, for two reasons:
secrets.GITHUB_TOKEN
does not have sufficient permissions to write to this repository/ branch, I believe- the trigger for this workflow is
on: push: branches: master
however this is unrelated to the event that we're interested in, which is pushes tomaster
ontheos/theos.dev
- both Lightmann and I originally thought this would work because
update-submodules
would run on organization pushes, however pushes totheos.dev
would not result in a commit to this repository and therefore would not trigger this workflow
- both Lightmann and I originally thought this would work because
The first part of my previous comment was not correct: |
Co-authored-by: Leptos <leptos.0.null@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for checking a big item off the to-do list.
What does this implement/fix? Explain your changes.
See title
Does this close any currently open issues?
No, but it will tick another item off of #308
Any relevant logs, error output, etc?
Any other comments?
Tested on separate branch and worked like a charm. Would be nice if we could only run the workflow if theos/theos.dev is updated, but not sure that's possible.
Edit: CSS looks to be borked atmWhere has this been tested?
Operating System: …
Linux (WSL)
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …