Fix: systemHasAnsiSupport() throws an error when STDOUT is not defined #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PhpUnit upgraded to 9.5.0 - `assertInternalType` has been deprecated. This has been removed from the tests. - Annotation `@doesNotPerformAssertions` to test that have no assertions - Removed `syntaxCheck` attribute from phpunit.xml as this is no longer a valid attribute - .gitignore file updated to ignore .phpunit.result.cache` which is sometimes created when running `phpunit` from `vendor/bin`
`systemHasAnsiSupport()` in Linux throws an error in the cases where the constant `STDOUT` is undefined. `systemHasAnsiSupport()` is changed to return false in this instance. See: https://stackoverflow.com/questions/17769041/notice-use-of-undefined-constant-stdout-assumed-stdout/28898174 Closes: 172
|
Closing due to the number commits file changes that this PR somehow grabbed unrelated to the actual code change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util/System/Linux::systemHasAnsiSupport()throws an error in the cases where the constantSTDOUTis undefined.Fixed
systemHasAnsiSupport()to return false in this instance.Closes: #172
See: https://stackoverflow.com/questions/17769041/notice-use-of-undefined-constant-stdout-assumed-stdout/28898174