work around while waiting for PHP fix for #279

thephpleague · Feb 5, 2018 · 92f7d62 · 92f7d62
1 parent 7645898
commit 92f7d62
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 3 deletions.
diff --git a/src/Reader.php b/src/Reader.php
@@ -114,10 +114,23 @@ public function getHeader(): array
      */
     protected function setHeader(int $offset): array
     {
+        $header = [];
         $this->document->setFlags(SplFileObject::READ_CSV | SplFileObject::READ_AHEAD | SplFileObject::SKIP_EMPTY);
         $this->document->setCsvControl($this->delimiter, $this->enclosure, $this->escape);
-        $this->document->seek($offset);
-        if (empty($header = $this->document->current())) {
+        if ($this->document instanceof Stream || PHP_VERSION_ID < 70200) {
+            $this->document->seek($offset);
+            $header = $this->document->current();
+        } else {
+            $stream->rewind();
+            while ($offset !== $stream->key() && $stream->valid()) {
+                $stream->current();
+                $stream->next();
+            }
+
+            $header = $stream->current();
+        }
+
+        if (empty($header)) {
             throw new Exception(sprintf('The header record does not exist or is empty at offset: `%s`', $offset));
         }
 

diff --git a/tests/ReaderTest.php b/tests/ReaderTest.php
@@ -291,12 +291,37 @@ public function appliedFlagsProvider()
     /**
      * @covers ::setHeader
      */
-    public function testGetHeaderThrowsException()
+    public function testGetHeaderThrowsExceptionWithNegativeOffset()
+    {
+        $this->expectException(Exception::class);
+        $this->csv->setHeaderOffset(-3)->getRecords();
+    }
+
+    /**
+     * @covers ::setHeader
+     */
+    public function testGetHeaderThrowsExceptionWithSplFileObject()
     {
         $this->expectException(Exception::class);
         $this->csv->setHeaderOffset(23)->getRecords();
     }
 
+    /**
+     * @covers ::setHeader
+     */
+    public function testGetHeaderThrowsExceptionWithStreamObject()
+    {
+        $this->expectException(Exception::class);
+
+        $tmp = fopen('php://temp', 'r+');
+        foreach ($this->expected as $row) {
+            fputcsv($tmp, $row);
+        }
+
+        $csv = Reader::createFromStream($tmp);
+        $csv->setHeaderOffset(23)->getRecords();
+    }
+
     /**
      * @covers ::setHeaderOffset
      * @covers \League\Csv\is_nullable_int