Collection id check for getIdFromData
#325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -358,7 +358,7 @@ protected function parseRelationships($includedData) | |||
| */ | |||
| protected function getIdFromData(array $data) | |||
| { | |||
| if (!array_key_exists('id', $data)) { | |||
| if (!array_key_exists('id', $data) || (!is_string($data['id']) && !is_numeric($data['id']))) { | |||
There was a problem hiding this comment.
I think we'd like to accept anything that can be cast as a string. We'd want to check something along the lines of is_scalar or implements __toString(). I don't see any reason not to allow string-able ids.
There was a problem hiding this comment.
Makes sense to me. I've updated the PR. Unfortunately that condition will not win any beauty pageants... I've added more test cases as well.
|
Hi @countless-integers, would you mind reopening this PR against the new separate JSON:API Serializer repo? That way we can get this released in 1.0 with commit credit to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the id in collection check to include dummy type check. Believe it or not I've run into an issue that could be remedied by this.