Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save pjpg as jpg when including file extensions #194

Merged
merged 1 commit into from
May 9, 2017
Merged

Save pjpg as jpg when including file extensions #194

merged 1 commit into from
May 9, 2017

Conversation

jasonvarga
Copy link
Contributor

When you enable setCacheWithFileExtensions and use fm=pjpg, the file was being saved as .pjpg. Now it'll use jpg.

I'm not sure if this is the best way to fix it.

@reinink
Copy link
Contributor

reinink commented May 9, 2017

Thanks @jasonvarga, you've been awesome as always with this library! The pjpg format has created way too many bugs in this library. Fortunately that goes away in V2, which has simplified a bunch of things.

@reinink reinink merged commit 8077f52 into thephpleague:master May 9, 2017
@reinink
Copy link
Contributor

reinink commented May 9, 2017

Tagged: https://github.com/thephpleague/glide/releases/tag/1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonvarga @reinink