Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure temp directory #304

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Conversation

tgalopin
Copy link
Member

Introduce the ability to configure the temporary directory used to store EXIF data. It's an adaptation of @jaapio work in #165, thanks for the PR!

Replace #165
Fixes #156
Fixes #186

@piotr-cz
Copy link

This looks great,
what do you think about adding temp_dir to ServerFactory default options with fallback value of sys_get_temp_dir()?

@tgalopin
Copy link
Member Author

Good idea, I'll do that

@tgalopin tgalopin merged commit 13c3f94 into master Jan 24, 2021
@tgalopin tgalopin deleted the allow-configure-temp-dir branch January 24, 2021 09:41
@piotr-cz
Copy link

Thanks!

@piotr-cz
Copy link

piotr-cz commented Apr 6, 2021

It seems that this PR has never been published in any release yet

@tgalopin
Copy link
Member Author

tgalopin commented Apr 6, 2021

It is released in 2.0 but not in 1.x indeed. I'll release it when I have time (not this week)

@piotr-cz
Copy link

piotr-cz commented Apr 6, 2021

Thanks, I've migrated to 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tempnam() error, while using hostings :) Server temp dir should be configurable
2 participants