Improve type: number validation (#69)

src/Constraints/Type.php

@@ -27,7 +27,13 @@ public static function validate($value, $type, $pointer = null)
             case 'null':
                 return self::validateType($value, $type, 'is_null', ErrorCode::INVALID_NULL, $pointer);
             case 'number':
-                return self::validateType($value, $type, 'is_numeric', ErrorCode::INVALID_NUMERIC, $pointer);
+                return self::validateType(
+                    $value,
+                    $type,
+                    'League\JsonGuard\is_json_number',
+                    ErrorCode::INVALID_NUMERIC,
+                    $pointer
+                );
             case 'integer':
                 return self::validateType(
                     $value,

src/functions.php

@@ -131,7 +131,7 @@ function escape_pointer($pointer)
  * Determines if the value is an integer or an integer that was cast to a string
  * because it is larger than PHP_INT_MAX.
  *
- * @param  mixed  $value
+ * @param  mixed $value
  * @return boolean
  */
 function is_json_integer($value)
@@ -143,6 +143,19 @@ function is_json_integer($value)
     return is_int($value) || (is_string($value) && ctype_digit($value) && compare($value, PHP_INT_MAX) === 1);
 }
 
+/**
+ * Determines if the value is a number.  A number is a float, integer, or a number that was cast
+ * to a string because it is larger than PHP_INT_MAX.
+ *
+ * @param mixed $value
+ *
+ * @return boolean
+ */
+function is_json_number($value)
+{
+    return is_float($value) || is_json_integer($value);
+}
+
 /**
  * @param string|double|int $leftOperand
  * @param string|double|int $rightOperand

tests/Constraints/TypeTest.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace League\JsonGuard\Test\Constraints;
+
+use League\JsonGuard\Constraints\Type;
+use League\JsonGuard\ValidationError;
+
+class TypeTest extends \PHPUnit_Framework_TestCase
+{
+    public function testNumericStringIsNotANumber()
+    {
+        $type = new Type();
+
+        $error = $type->validate('1', 'number');
+
+        $this->assertInstanceOf(ValidationError::class, $error);
+    }
+}