This repository has been archived by the owner on May 12, 2018. It is now read-only.
More URI resolution fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matt-allan
commented
Oct 27, 2016
•
matt-allan
commented
- properly replace the last component of a path
- Remove lots of code
- Add a todo for file URIs
|
I opened sabre-io/uri#10 to resolve the |
evert
reviewed
Oct 27, 2016
| @@ -205,17 +205,28 @@ function resolve_uri($id, $parentScope) | |||
| $parts = Uri\parse($id); | |||
|
|
|||
| if (!empty($parts['path'])) { | |||
| // If the path ends in a slash, it shouldn't be replaced but instead appended to. | |||
| // If the original path ends in a slash, it shouldn't be replaced but instead appended to. | |||
There was a problem hiding this comment.
Did you consider Sabre\Uri\resolve for this? Curious if it's not good enough, or if there's something I can improve
There was a problem hiding this comment.
I thought there was a reason I couldn't use it, but all of the tests seem to pass.
IIRC the issue was just that the spec expected me to keep an extraneous '#' if it existed on the base URI, even if there wasn't a fragment. It doesn't actually affect schema resolution though.
Anyway, that saves me from maintaining quite a bit of error prone code, so thanks 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.