Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Dropbox provider #221

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Add link to Dropbox provider #221

merged 1 commit into from
Feb 12, 2015

Conversation

jasonvarga
Copy link
Contributor

No description provided.

@ramsey
Copy link
Contributor

ramsey commented Feb 12, 2015

Thanks! Might want to use ~0.8.1 in your composer.json, rather than ~0.8, just in case some project somewhere hard locks oauth2-client to 0.8.0 and tries to use the Dropbox provider.

ramsey added a commit that referenced this pull request Feb 12, 2015
@ramsey
Merge pull request #221 from jasonvarga/patch-1
e18c99c 
Add link to Dropbox provider
@ramsey ramsey merged commit e18c99c into thephpleague:master Feb 12, 2015
@jasonvarga
Copy link
Contributor Author

Good call, done. Thanks!

@jasonvarga jasonvarga deleted the patch-1 branch February 12, 2015 18:58
@philsturgeon
Copy link
Member

The larger concern with ~0.8 is that 0.9 can have BC breaks according to SemVer, and 1.0 definitely will. While you require any 0.x version always be specific with 0.8.* or 0.8.1.

That is what @ramsey suggested, but for a different reason. :)

@jasonvarga
Copy link
Contributor Author

Makes sense. Thanks Phil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonvarga @ramsey @philsturgeon