Fully document the ProviderInterface

[shadowhand]

Move existing documentation from AbstractProvider and fill in any missing docblocks.

[shadowhand]

@ramsey This method was missing from the interface. As per our discussion earlier about the error handling flow, I plan to modify this method (and name it better).

[shadowhand]

@ramsey I'm not sure why this build failed only on HHVM... any clue?

[ramsey]

The failure message on HHVM is:

Fatal error: Class Mock_AbstractProvider_c5873f51 contains abstract method (urlAuthorize) and must therefore be declared abstract or implement the remaining methods in /home/travis/build/thephpleague/oauth2-client/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Generator.php(301) : eval()'d code on line 1

I'm not sure why it's specific to HHVM, though.

[shadowhand]

@ramsey found the issue, it's a HHVM bug: sebastianbergmann/phpunit-mock-objects#223 and facebook/hhvm#5170. Should I apply the work around (define the methods in the abstract class) or are we okay with breaking HHVM usage?

[ramsey]

Is this only because our mock provider doesn't fully implement all the methods? Or is it a general issue with abstract classes in HHVM, where they always need to implement the full interface?

If it's only an issue with our mock provider for the tests, then please define the methods in the mock object for the test. Otherwise, let's think about it for a bit. I want to follow up with HHVM folks to see if this is something they'll be fixing in future versions.

[shadowhand]

@ramsey based on the HHVM issue I referenced, it looks like they intend to fix it, but have no timeline for doing so. I think the best thing to do for now would be to implement all the methods in the abstract.

[ramsey]

Okay. That's fine. When HHVM does fix it, we can remove them.

[shadowhand]

@ramsey added here as a separate commit that can be reverted in the future.

[coveralls]

Coverage increased (+0.08%) to 84.78% when pulling 4d998f5 on shadowhand:feature/v1-interface-docblocks into b9e6b72 on thephpleague:1.0.

[shadowhand]

Strange the coverage decreased, since no actual code was modified. I guess it's because of the added abstract methods.

Also, I made a quick script to check these after I kept missing methods.

[ramsey]

Thanks!