Add hasExpired to AccessToken #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
| public function hasExpired() | ||
| { | ||
| if (!isset($this->expires)) { | ||
| throw new InvalidArgumentException('"expires" is not set on the token'); |
There was a problem hiding this comment.
I'm not sure that using InvalidArgumentException is the best choice here, because there is no argument at play. A better choice would be RuntimeException.
There was a problem hiding this comment.
I gave that some thought, too, but I wasn't sure what would best fit. I think you're right: RuntimeException would be best.
There was a problem hiding this comment.
I thought about this too when I was writing it and went through all descriptions for them. I figured that it's an InvalidArgumentException because 'expires' is an invalid argument because it's not set. Another thought was to not throw and exception at all, but return false instead if not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like an easy value-add to the token, even though it doesn't technically solve a problem. Makes it easy to check if a token should be refreshed when a request is made.