Check if property publicProfileUrl exists in LinkedIn response
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct before accessing it directly.
|
👍 |
|
Thanks. Merging in, but also pinging @stevenmaguire to make sure this isn't in the external LinkedIn library. |
ramsey
added a commit
that referenced
this pull request
Jun 11, 2015
Check if property `publicProfileUrl` exists in LinkedIn response
|
This does not appear to be a problem in the external library, which has a different implementation for null/not set. https://github.com/thephpleague/oauth2-linkedin/blob/master/src/Provider/LinkedIn.php#L80 @leandersikma feel free to pull the project and write a test to validate this against your scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a scenario where the publicProfileUrl is not set, which results in a PHP notice.