Added some AccessToken typehints where appropriate #360
Conversation
|
I think in some cases, we were expecting that the provider might pass the string access token instead of the object to some of these methods. If we decide they must always pass an AccessToken, then I'm fine with that. @shadowhand, any thoughts? |
|
I believe it's in our interest to be strict with parameter types and provide flexibility with clever methods instead. So keep the rules and policies specific, but give providers enough access to adjust things accordingly. However, if there is a use case or requirement for using a string, then I'm happy to document the expected type as |
|
I agree with you. I'm just trying to make sure I'm not forgetting something. :-) |
|
Absolutely, there's no urgency for this so I don't mind hanging around for a while. |
| * @return array | ||
| */ | ||
| protected function getDefaultHeaders($token = null) | ||
| protected function getDefaultHeaders(AccessToken $token = null) |
There was a problem hiding this comment.
As per my comments on #359, this method shouldn't even have a $token parameter.
|
👎 for the reasons I listed. This offers no real benefits for end users. |
Unless there is a good reason not to do this?