Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mockery with Phony #584

Merged
merged 4 commits into from Nov 4, 2016
Merged

Conversation

shadowhand
Copy link
Member

The expect-run-verify model of testing does not mirror how code is
actually developed. A mock-run-verify approach allows faster prototyping
and reflects how code is actually executed.

Phony has additional features, such as order verification.

https://github.com/eloquent/phony#inception

@shadowhand shadowhand added this to the v2.0 milestone Nov 3, 2016
@coveralls
Copy link

coveralls commented Nov 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling eff6d89 on feature/replace-mockery-with-phony into 04a2612 on 2.x.

The expect-run-verify model of testing does not mirror how code is
actually developed. A mock-run-verify approach allows faster prototyping
and reflects how code is actually executed.

Phony has additional features, such as order verification.

https://github.com/eloquent/phony#inception
@shadowhand shadowhand force-pushed the feature/replace-mockery-with-phony branch from eff6d89 to 22c3cb7 Compare November 3, 2016 17:06
@shadowhand
Copy link
Member Author

@ramsey any objections to this change?

@coveralls
Copy link

coveralls commented Nov 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 22c3cb7 on feature/replace-mockery-with-phony into 0958ebd on 2.x.

@coveralls
Copy link

coveralls commented Nov 3, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 2aa6980 on feature/replace-mockery-with-phony into 0958ebd on 2.x.

@ramsey
Copy link
Contributor

ramsey commented Nov 3, 2016

@shadowhand No objections. Looks good.

@shadowhand shadowhand force-pushed the feature/replace-mockery-with-phony branch from 19b1462 to 1c58178 Compare November 4, 2016 13:25
@coveralls
Copy link

coveralls commented Nov 4, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1c58178 on feature/replace-mockery-with-phony into 0958ebd on 2.x.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1c58178 on feature/replace-mockery-with-phony into 0958ebd on 2.x.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1c58178 on feature/replace-mockery-with-phony into 0958ebd on 2.x.

@shadowhand shadowhand merged commit c24bb0f into 2.x Nov 4, 2016
@shadowhand shadowhand deleted the feature/replace-mockery-with-phony branch November 4, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants