Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oauth2-phabricator to thirdparty #591

Merged
merged 1 commit into from
Nov 22, 2016
Merged

add oauth2-phabricator to thirdparty #591

merged 1 commit into from
Nov 22, 2016

Conversation

ofbeaton
Copy link
Contributor

@ofbeaton ofbeaton commented Nov 21, 2016

Wrote a provider for using the oauth2 server capability of the phabricator code review system. It's not a cloud service per se but one you run yourself.

https://github.com/ofbeaton/oauth2-phabricator

I have 100% code coverage and I've already started using it in production.

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 67d0284 on ofbeaton:oauth2-phabricator into 18924c1 on thephpleague:master.

@shadowhand
Copy link
Member

I reviewed the code and found a couple of minor issues that could be addressed. Will accept this anyways, since they are non-blocking.

Thanks!

@shadowhand shadowhand merged commit 8641db6 into thephpleague:master Nov 22, 2016
@ofbeaton
Copy link
Contributor Author

Thanks for merging, and for taking the time to review the code. I've fixed all outstanding issues and performed another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants