Remove removed scopes from default and fix unit tests #59
Conversation
…t to fetch 'cover{source}'
|
Thank you @mikealmond & @grifx :) |
|
Hey guys! Sorry to heckle you all but any ETA on the merge of this PR? I feel like a number of us have a hacky vendor file edit on prod as a workaround while we wait for #55 to be resolved 😅 Thanks! ❤️ |
Well, we can't do much more here than wait for the maintainer (@SammyK) to approve the PR. I have tried to reach out to him on LinkedIn as well, hopefully he will get the message but as you can see, this package is not that active anymore, the last release was 3 years ago. In the meantime, we shared a few solution to get around this issue here: |
|
I can merge it... but to be honest I've never done this outside of the context of my own library. Not sure if I would be overstepping any boundaries here. |
|
Also willing to take ownership if that is truely nonexistent. But no idea what the process for this is. |
@alcohol thanks for your reply. I perfectly understand, I was hopping that you or someone from the team may be able to reach out more easily to @SammyK or someone else who would be confortable to do it. |
|
@shadowhand any chance you could help here as you already working on oauth2-facebook & oauth2-client & oauth2-google ? Or @Sephster as you work on oauth2-server |
| @@ -103,7 +103,7 @@ public function getResourceOwnerDetailsUrl(AccessToken $token) | |||
| $fields = [ | |||
| 'id', 'name', 'first_name', 'last_name', | |||
| 'email', 'hometown', 'picture.type(large){url,is_silhouette}', | |||
| 'cover{source}', 'gender', 'locale', 'link', 'timezone', 'age_range' | |||
There was a problem hiding this comment.
Does cover no longer exist in the API?
|
Released in version 2.0.2. |
|
Huge Thanks for your help with this matter @shadowhand ! |
Merges #53 and #54 with some additional fixes.