Implicit grant now handles scope like password grant, keys and tokens are now case-sensitive #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephspurrier
changed the title
|
👍 |
|
|
||
| for ($i = 0; $i < count($scopes); $i++) { | ||
| $scopes[$i] = trim($scopes[$i]); | ||
| if ($scopes[$i] === '') unset($scopes[$i]); // Remove any junk scopes |
There was a problem hiding this comment.
this entire foreach block can be replaced with:
$scopes = array_filter($scopes);
|
@alexbilbie can you comment a little bit more on close status? Is this integrated with v4, or simply too old to be merged? |
|
I've removed the implicit grant in v4. I will consider a sibling package that adds support but I don't want it to be part of the main library because it isn't safe to use (in terms of the grant from the main spec, not just this implementation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tools.ietf.org/html/rfc6749#section-4.2.1
The scope should be pulled from $authParams['scope'](without an s). The scope should also be handled the same way as the other grants.