Fix Resource server Request HTTP header access #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is bogus, PHP 5.5 failed because the timing was off-by-one second: https://travis-ci.org/thephpleague/oauth2-server/jobs/30601056 |
| } else { | ||
| // @codeCoverageIgnoreEnd | ||
| $headers = array(); | ||
| foreach ($this->server() as $name => $value) { | ||
| if (substr($name, 0, 5) == 'HTTP_') { | ||
| $name = str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5))))); | ||
| // HTTP_FOO_BAR becomes FOO-BAR | ||
| $name = str_replace(array('HTTP_', '_'), array('', '-'), $name); |
There was a problem hiding this comment.
Format of the values is different here, but it doesn't matter because of the normalizeHeaders call below.
|
Cheers @shadowhand, I've also removed than annoying assertion that breaks when comparing seconds in v4 |
|
(oops, didn't mean to close before merging) |
|
Sorry Github seems to be stuck on this:
|
|
I did a force push, it should be okay to merge now. :) |
alexbilbie
added a commit
that referenced
this pull request
Jul 23, 2014
Fix Resource server Request HTTP header access
|
Thanks @alexbilbie! Can you also tag a new release so that we can start using this? |
|
On it |
|
Thanks! It fixed our build! 👯 https://travis-ci.org/ushahidi/platform/jobs/30665593 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using a raw
new Requestcall, which only works with Apache, useRequest:: buildFromGlobalsto work in other scenarios. Also expands and cleans up theUtil\Request::readHeadersmethod and adds support for the http extension.