Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API support #21

Merged
merged 11 commits into from Jan 7, 2015
Merged

Conversation

markguinn
Copy link
Contributor

Because of the way the ProGateway and ExpressGateway interact, I chose to implement the REST support as a separate RestGateway. I was in touch with PayPal support during this process as well and they indicated that the REST API is not ready to fully replace the classic API's yet, which confirms the decision for me. It's necessary to support create/update/deleteCard though.

@amacneil
Copy link
Member

amacneil commented Jul 8, 2014

Hey thanks, this looks great! I think you're right about creating a separate gateway - the rest API isn't even available in all countries yet I don't think.

On the surface this looks good, but I'll dig into it more thoroughly soon and see if we can get it merged.

@amacneil amacneil mentioned this pull request Jul 8, 2014
@dkyosev
Copy link

dkyosev commented Oct 2, 2014

@adrianmacneil @markguinn Hi there, what is the state of this PR?
I'm planning on using Omnipay with PayPal's REST API and just wondering if this needs more work and if it does, can i help?

@markguinn
Copy link
Contributor Author

From my standpoint its at least beta quality. We're launching a site using this code in the next month or so.

@markguinn
Copy link
Contributor Author

@adrianmacneil any more news or feedback on getting this merged? We're about to launch a site using this code and it'd be great to have it pointed at an official version number instead of my fork. I'm happy to make changes if needed.

@amacneil
Copy link
Member

amacneil commented Jan 7, 2015

@kayladnls is maintaining this project now, will leave it up to her to merge.

@greydnls
Copy link
Contributor

greydnls commented Jan 7, 2015

Everything here looks good @markguinn Thanks for your work on this!

greydnls added a commit that referenced this pull request Jan 7, 2015
@greydnls greydnls merged commit e97a944 into thephpleague:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants