Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sage Pay Form #112

Closed
judgej opened this issue Sep 25, 2018 · 5 comments
Closed

Support Sage Pay Form #112

judgej opened this issue Sep 25, 2018 · 5 comments
Assignees
@judgej
Labels
enhancement

Comments

@judgej
Copy link
Member

judgej commented Sep 25, 2018

Though mostly front end, Sage Pay Form shares a lot of the back end APIs and data structures with Server and Direct.
@judgej judgej self-assigned this Sep 25, 2018
judgej added a commit to academe/omnipay-sagepay that referenced this issue Sep 26, 2018
@judgej
Issue thephpleague#112 start Sage Page Form
6b23fac
@judgej
Copy link
Member Author

judgej commented Sep 30, 2018 •
edited
Loading

This API does not provide a securityKey with the result, so repeat payments are not possible with that result. However, fetching the transaction from the gateway should provide that detail, so we will need to implement fetchTransaction.

However, there are no plans for this at this time, as the fetchTransaction command uses the XML-based reporting and management API, which is a whole new thing largely out of scope in general for Omnipay.

judgej added a commit to academe/omnipay-sagepay that referenced this issue Sep 30, 2018
@judgej
Issue thephpleague#112 and thephpleague#114 - mainly Sage Pay Form su…
72d6a78 
…pport.

For thephpleague#114 the `billingForShipping` flag copies the billing address
to the delivery address, so only the billing address needs to
be supplied.
@judgej
Copy link
Member Author

judgej commented Sep 30, 2018 •
edited
Loading

This is now functional, though there are some additional message parameters to support for Form initiation only, and some tests for the encryption algorithms.

@judgej
Copy link
Member Author

judgej commented Sep 30, 2018

The encryption uses openssl and not PHP's mcrypt (which is deprecated as of PHP 7.1

@judgej
Copy link
Member Author

judgej commented Oct 4, 2018

The linked branch now supports Sage Pay Form if anyone else would like to try it out. It needs more tests, and there are some Form-only features and parameters to be added, but it is functional. It needs openssl to be available, as it does not have a fallback to mcrypt (this can be added if anyone wants to provide it - should be simple enough).

judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 7, 2018
@judgej
Issue thephpleague#112 take vendorTxCode supplied by gateway for tran…
56174cf 
…sactionReference, where available.
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 7, 2018
@judgej
Issue thephpleague#112 check all mandatory fields are present before …
b90b693 
…`Form` direct.
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 7, 2018
@judgej
Issue thephpleague#112 Tests for Sage Pay Form - encrypting and decry…
39a17ef 
…pting
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 7, 2018
@judgej
Issue thephpleague#112 Support Sage Pay Form email notifications and …
11fe46b 
…gift aid
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 13, 2018
@judgej
Issue thephpleague#112 additional validation on encypted response fro…
471a4fb 
…m gateway
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 13, 2018
@judgej
Issue thephpleague#112 Recode Sage Pay Form data from UTF-8 to ISO885…
1fa282a 
…9-1 by default.

Provide an option to disable this for when the merchant site handles
it already. In the vast number of cases, the conversion should stand.
That is, until Sage Pay get their ISO8859 technical debt sorted out
for good.
judgej added a commit to academe/omnipay-sagepay that referenced this issue Oct 14, 2018
@judgej
Issue thephpleague#112 Additional docs on how Sage Pay Form works.
110080c
@judgej
Copy link
Member Author

judgej commented Oct 21, 2018

Released as 3.2.0

@judgej judgej closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judgej judgej

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judgej