Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server and Direct: delivery address is mandatory #114

Closed
judgej opened this issue Sep 26, 2018 · 2 comments
Closed

Server and Direct: delivery address is mandatory #114

judgej opened this issue Sep 26, 2018 · 2 comments
Assignees
@judgej
Labels
enhancement

Comments

@judgej
Copy link
Member

judgej commented Sep 26, 2018

Most gateways do not have a mandatory delivery address, but Sage Pay does when registering a transaction. For consistency, this driver should protect the application from that inconsistency.

I propose that a missing delivery address is automatically populated from the billing address. To reduce BC breaks, this should probably be an option that can be set at the gateway level, defaulting to off.
@judgej
Copy link
Member Author

judgej commented Sep 29, 2018

Rather than setting the delivery address the same as the billing address if it is empty, a single flag to explicitly copy it across should be used - but the control entirely in the hands of the merchant site. Maybe something like shippingAsBilling.

judgej added a commit to academe/omnipay-sagepay that referenced this issue Sep 30, 2018
@judgej
Issue thephpleague#112 and thephpleague#114 - mainly Sage Pay Form su…
72d6a78 
…pport.

For thephpleague#114 the `billingForShipping` flag copies the billing address
to the delivery address, so only the billing address needs to
be supplied.
@judgej judgej mentioned this issue Oct 7, 2018
Merged
@judgej judgej self-assigned this Oct 13, 2018
@judgej
Copy link
Member Author

judgej commented Oct 21, 2018

Released as 3.2.0

@judgej judgej closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judgej judgej

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judgej