Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed application fee for PaymentIntent #155

Conversation

fotomerchant
Copy link

@fotomerchant fotomerchant commented Sep 17, 2019

As per https://stripe.com/docs/api/payment_intents/create, the request parameter for Payment Intent application_fee_amount when specifying the application fee for Stripe Connect scenarios.

@tafid
Copy link

tafid commented May 27, 2020

As per https://stripe.com/docs/api/payment_intents/create, the request parameter for Payment Intent application_fee_amount when specifying the application fee for Stripe Connect scenarios.

Hi! According Stripe official documentation and Core Resource section, the Charge object may consist both application_fee and application_fee_amount attributes. May be you should just add application_fee_amount instead to change application_fee attribute?

@alexsegura
Copy link

Whereas my comment #172 (comment) is not totally true for Charges, in the case of PaymentIntents, it needs to be changed to application_fee_amount 🙂

@gmoreira can you rebase the PR, please? This one should definitely be merged.

…ub.com/fotomerchant/omnipay-stripe into feature/payment-intent-application-fee

* 'feature/payment-intent-application-fee' of https://github.com/fotomerchant/omnipay-stripe:
  Fixed application fee request parameter when creating a PaymentIntent.

# Conflicts:
#	tests/Message/PaymentIntents/AuthorizeRequestTest.php
@fotomerchant fotomerchant deleted the feature/payment-intent-application-fee branch August 19, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants