Add default response header support #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowhand
commented
Oct 10, 2018
| $response->getBody()->write($body); | ||
| } | ||
|
|
||
| if ($response instanceof ResponseInterface && ! $response->hasHeader('content-type')) { | ||
| $response = $response->withAddedHeader('content-type', 'application/json'); |
There was a problem hiding this comment.
I used withHeader instead of withAddedHeader because all of hasHeader checks, which invalidate the need to use withAddedHeader.
| @@ -39,14 +41,11 @@ public function invokeRouteCallable(Route $route, ServerRequestInterface $reques | |||
|
|
|||
| if ($this->isJsonEncodable($response)) { | |||
| $body = json_encode($response); | |||
| $response = $this->responseFactory->createResponse(); | |||
| $response = $response->withStatus(200); | |||
There was a problem hiding this comment.
No need for this, as the default for createResponse is a response with HTTP 200 status. I still made the status explicit for clarity.
Also, I did not modify JsonStrategy::getExceptionHandler response handling, as there is no assurance that the body would conform to a custom JSON format like JSON-API or HAL. Since the body defined for an exception is explicit, it would likely cause issues to apply the default headers.
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #205