Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psr/simple-cache version constraint. Fixes #320 #321

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

arabcoders
Copy link

Widen psr/simple-cache version constraint to support 1.0|2.0|3.0.
Fixes #320

Widen psr/simple-cache version constraint to support 1.0|2.0|3.0.
Fixes thephpleague#320
@philipobenito
Copy link
Member

Sorry for the delay on this, will be merging and tagging early next week.

@philipobenito
Copy link
Member

This actually causes an issue on PHP 8 as there is a method signature change

@arabcoders
Copy link
Author

This actually causes an issue on PHP 8 as there is a method signature change

Hmm.. im using this in my composer.json

{
    "require": {
        "psr/simple-cache": "3.0 as 1.0",
    }
}

and not getting any errors from router or anything and i have error_reporting set to E_ALL and running PHP 8.1

@sneakyvv
Copy link

What was the error? The logs for the tests have been removed already :\

@arabcoders
Copy link
Author

What was the error? The logs for the tests have been removed already :\

locking dependency on 1.0 causes conflicts as a lot of packages have moved on to 3.0

@sneakyvv
Copy link

So what's the plan for this @philipobenito, can't these other dependencies be updated/upgraded as well?

@sneakyvv
Copy link

sneakyvv commented Jan 5, 2023

This actually causes an issue on PHP 8 as there is a method signature change

@philipobenito, sorry to push for this again, but can you elaborate, so we can move away from the 7-year old dependency?

@sneakyvv
Copy link

sneakyvv commented Jan 5, 2023

@philipobenito I investigated it myself, and understand the issue now. To be able to fix this, support for PHP7 needs to be dropped, which is what #327 is about.

@sneakyvv
Copy link

No takers?

@philipobenito
Copy link
Member

philipobenito commented Jan 26, 2023 via email

@sneakyvv
Copy link

Oh sorry to hear that, take care!

@sneakyvv
Copy link

@philipobenito did you have a change to look at this?

@rikgirbes
Copy link

any updates to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psr/simple-cache version constraints
4 participants