Drop support for PHP 7 #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2023 12:57
Adjust code to new standards
Was wrongly annotated before
|
Already handled for a 6.x release in a couple of days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As #321 showed, there's an issue to upgrade the
psr/simple-cachepackage since it changed its PHP constraint to>=8.0.0, and therefore this package's implementation of theCacheInterfaceinFileCacheis no longer compatible withpsr/simple-cachebecause it's using the newmixedtype.Solution
Drop support for PHP7. It's EOL since end of 11/2022, so now is the time to let it go.
NOTE