Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client->timings() to send multiple values at once #51

Merged
merged 2 commits into from
Jun 12, 2018

Conversation

xosofox
Copy link
Contributor

@xosofox xosofox commented May 29, 2018

instead of using multiple timing() calls, use a key-value map for timings()

@marcqualie
Copy link
Member

Thanks for contribution @xosofox!

@marcqualie marcqualie merged commit 5b12000 into thephpleague:master Jun 12, 2018
@fedeisas
Copy link

@xosofox is there any reason why this doesn't allow for multiple timers with the same key. I'm trying to bulk my StatsD metrics (https://github.com/statsd/statsd/blob/master/docs/metric_types.md#multi-metric-packets) but sometimes I have many instances of the same timer. I ask because I'm not a StatsD expert and I might be missing something.

@xosofox
Copy link
Contributor Author

xosofox commented Mar 28, 2019

@xosofox is there any reason why this doesn't allow for multiple timers

There is no 'real' reason besides the fact that I didn't see that use case (in my project).
So I just used a simple array with key=>value. The function could of course be extend to check if the values of the passed array are key=>value pairs again.

You might want to check the code and give it a shot in another Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants