Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling of Edit Post button on your own post #1740

Closed
sarthology opened this issue Feb 5, 2019 · 3 comments · Fixed by #1749
Closed

Styling of Edit Post button on your own post #1740

sarthology opened this issue Feb 5, 2019 · 3 comments · Fixed by #1749
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@sarthology
Copy link
Contributor

Describe the bug
In all the devices, below the size of 475px, the *Edit Post" button have every small top margin.

To Reproduce
Steps to reproduce the behavior:

  1. Go to your profile on mobile
  2. Click on any of your posts
  3. See error

Expected behavior
It should have more space than that.

Screenshots
photo_2019-02-05_17-21-53
@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Feb 5, 2019
@triage-new-issues triage-new-issues bot removed the triage label Feb 5, 2019
@jessleenyc jessleenyc removed the external contributors welcome contribution is welcome! label Feb 5, 2019
@jessleenyc jessleenyc self-assigned this Feb 5, 2019
@jessleenyc jessleenyc added bug always open for contribution external contributors welcome contribution is welcome! labels Feb 5, 2019
@jessleenyc
Copy link
Contributor

Thanks for flagging this. This is approved if anyone wants to jump on it!

@jessleenyc jessleenyc removed their assignment Feb 5, 2019
@aligoren
Copy link
Contributor

aligoren commented Feb 5, 2019

I think I or anyone is here can change margin. But what should be margin value? 10 pixels in general?

@sarthology
Copy link
Contributor Author

Yeah 10px will do it.

aligoren added a commit to aligoren/dev.to that referenced this issue Feb 6, 2019
@aligoren
The issue 'Styling of Edit Post button on your own post' fixed. Closed …
455e8c4 
…forem#1740
@aligoren aligoren mentioned this issue Feb 6, 2019
Merged
7 tasks
benhalpern pushed a commit that referenced this issue Feb 6, 2019
@aligoren @benhalpern
The issue 'Styling of Edit Post button on your own post' fixed. Close… (
b927903 
#1749)

* The issue 'Styling of Edit Post button on your own post' fixed. Closed #1740

* I changed margin top to 4 and media screens's max-width value change as 376px
@weekly-digest weekly-digest bot mentioned this issue Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The issue 'Styling of Edit Post button on your own post' fixed. Close… aligoren/dev.to
3 participants
@sarthology @aligoren @jessleenyc