Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented ActiveJob for badge_achievements#send_email_notification #2962

Merged
merged 2 commits into from
May 27, 2019
Merged

Implemented ActiveJob for badge_achievements#send_email_notification #2962

merged 2 commits into from
May 27, 2019

Conversation

tannakartikey
Copy link
Contributor

@tannakartikey tannakartikey commented May 26, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Uses ActiveJob to send an email for BadgeAchivement

Related Tickets & Documents

#2497

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label May 26, 2019
rhymes
rhymes suggested changes May 26, 2019
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

app/jobs/badge_achievements/send_email_notification_job.rb Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels May 26, 2019
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels May 26, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels May 26, 2019
@weekly-digest weekly-digest bot mentioned this pull request May 27, 2019
Closed
lightalloy
lightalloy approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@lightalloy lightalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benhalpern benhalpern merged commit b16fa4f into forem:master May 27, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels May 27, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightalloy lightalloy lightalloy approved these changes

@rhymes rhymes rhymes approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannakartikey @lightalloy @rhymes @benhalpern