Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump organization listings with organization credits #3489

Merged

Conversation

mariocsee
Copy link
Contributor

@mariocsee mariocsee commented Jul 15, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Bug Fix

Description

Adds organization check for update method so organization credits can be used to bump a listing.

Related Tickets & Documents

resolves #3435

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

Added to documentation?

  • no documentation needed

@mariocsee mariocsee changed the title WIP Bump organization listings with organization credits Bump organization listings with organization credits Jul 15, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jul 15, 2019
@mariocsee mariocsee requested review from rhymes and removed request for rhymes July 15, 2019 21:52
Copy link
Contributor

@lightalloy lightalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding tests for the logic that was changed.

@mariocsee
Copy link
Contributor Author

I suggest adding tests for the logic that was changed.

Just added two tests for each case and updated one to check for the redirect.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jul 26, 2019
@benhalpern benhalpern merged commit 197cd56 into forem:master Jul 29, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jul 29, 2019
@mariocsee mariocsee deleted the mario/bump-listing-with-org-credits branch July 29, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listings: cannot bump a listing using org credits
3 participants