-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump organization listings with organization credits #3489
Merged
benhalpern
merged 7 commits into
forem:master
from
mariocsee:mario/bump-listing-with-org-credits
Jul 29, 2019
Merged
Bump organization listings with organization credits #3489
benhalpern
merged 7 commits into
forem:master
from
mariocsee:mario/bump-listing-with-org-credits
Jul 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocsee
changed the title
WIP Bump organization listings with organization credits
Bump organization listings with organization credits
Jul 15, 2019
lightalloy
reviewed
Jul 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding tests for the logic that was changed.
Just added two tests for each case and updated one to check for the redirect. |
lightalloy
approved these changes
Jul 26, 2019
pr-triage
bot
added
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
and removed
PR: unreviewed
bot applied label for PR's with no review
labels
Jul 26, 2019
pr-triage
bot
added
PR: merged
bot applied label for PR's that are merged
and removed
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
labels
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds organization check for update method so organization credits can be used to bump a listing.
Related Tickets & Documents
resolves #3435
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A
Added to documentation?