More updates to frontend documentation #5724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
previously approved these changes
Jan 26, 2020
Comment on lines
+20
to
+24
| - The | ||
| [Onboarding flow](https://github.com/thepracticaldev/dev.to/blob/master/app/javascript/packs/Onboarding.jsx#L28). | ||
| - In | ||
| [connect](https://github.com/thepracticaldev/dev.to/blob/master/app/javascript/chat/codeEditor.jsx#L11) | ||
| (chat) |
There was a problem hiding this comment.
You might want to use the permalinks here, instead of the the link, though maybe it's better to use the link because if we change those lines, then maybe someone will notice the link in the doc is broken instead of viewing the same file in a point in time, nevermind then :D
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: unreviewed
|
Merged latest from master as my changes shouldn't be breaking the build as it's just the docs site and it builds fine locally. |
pr-triage
bot
added
PR: reviewed-approved
benhalpern
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Some more additions to frontend documentation.
Related Tickets & Documents
#2507
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?