Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod channel automation to tags #5731

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Conversation

benhalpern
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR adds the functionality to map a dedicated mod channel for each tag automatically when mods are added. It also adds anyone with the mod_relations role to the channels.

After deployment
Since we already have some of these channels, we should add those channels to their appropriate tags via our console. Also add the mod relations role to relevant DEV team members.

@benhalpern benhalpern requested a review from a team January 26, 2020 18:13
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 26, 2020
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the Travis CI build output, it looks like there's something wrong in the migration (I've also noticed it didn't bump the schema version in schema.rb)

@rhymes rhymes requested review from jacobherrington and removed request for a team January 27, 2020 10:15
citizen428
citizen428 previously approved these changes Jan 28, 2020
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @benhalpern, LGTM! 🚀

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 28, 2020
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 6, 2020
@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ benhalpern
❌ Ben Halpern


Ben Halpern seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@benhalpern benhalpern merged commit f3c86c6 into master Feb 6, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Feb 6, 2020
@maestromac maestromac deleted the ben/private-moderator-channel branch February 6, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants