Remove ENV["USE_NEW_AWS"] and use Orig ENV variables for New Creds #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruve
requested review from
benhalpern,
atsmith813,
joshpuetz and
rhymes
and removed request for
benhalpern
pr-triage
bot
added
PR: reviewed-approved
rhymes
suggested changes
Jan 27, 2020
Envfile
Outdated
| @@ -73,6 +67,7 @@ variable :ALGOLIASEARCH_SEARCH_ONLY_KEY, :String, default: only_in_test | |||
| variable :AWS_ID, :String, default: "Optional" | |||
| variable :AWS_SECRET, :String, default: "Optional" | |||
| variable :AWS_BUCKET_NAME, :String, default: "Optional" | |||
| variable :AWS_UPLOAD_REGION, :String, default: "Optional" | |||
There was a problem hiding this comment.
this has to be an empty string, for the OR in the carrierwave initializer and the site map to work. Otherwise the app locally will boot with "Optional" as the region
Optional is just an arbitrary string I hope we can get rid of :D
There was a problem hiding this comment.
Oh snap! Good catch!
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
rhymes
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: reviewed-approved
atsmith813
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Now that we are pointed at our new AWS bucket swap over the original ENV variables to the new bucket ones and use those. The only variable we have to keep is the region since that is different than our default region and that default region is being used by the SDK which is used by the
AWS_LAMBDAclient.The ENV variables have all been set properly in Heroku.
AWS_SECRET = AWS_UPLOAD_SECRET
AWS_ID = AWS_UPLOAD_ID
AWS_BUCKET_NAME = AWS_UPLOAD_BUCKET_NAME
Related Tickets & Documents
#5570
Added to documentation?