-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ENV["USE_NEW_AWS"] and use Orig ENV variables for New Creds #5771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from fixing the default value of the environment variable I think we're there!
Thanks for the transition!
Envfile
Outdated
@@ -73,6 +67,7 @@ variable :ALGOLIASEARCH_SEARCH_ONLY_KEY, :String, default: only_in_test | |||
variable :AWS_ID, :String, default: "Optional" | |||
variable :AWS_SECRET, :String, default: "Optional" | |||
variable :AWS_BUCKET_NAME, :String, default: "Optional" | |||
variable :AWS_UPLOAD_REGION, :String, default: "Optional" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be an empty string, for the OR
in the carrierwave initializer and the site map to work. Otherwise the app locally will boot with "Optional" as the region
Optional
is just an arbitrary string I hope we can get rid of :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh snap! Good catch!
What type of PR is this? (check all applicable)
Description
Now that we are pointed at our new AWS bucket swap over the original ENV variables to the new bucket ones and use those. The only variable we have to keep is the region since that is different than our default region and that default region is being used by the SDK which is used by the
AWS_LAMBDA
client.The ENV variables have all been set properly in Heroku.
AWS_SECRET = AWS_UPLOAD_SECRET
AWS_ID = AWS_UPLOAD_ID
AWS_BUCKET_NAME = AWS_UPLOAD_BUCKET_NAME
Related Tickets & Documents
#5570
Added to documentation?