Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One less place you need to bump the ruby version #5780

Merged
merged 1 commit into from
Feb 3, 2020
Merged

One less place you need to bump the ruby version #5780

merged 1 commit into from
Feb 3, 2020

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Jan 28, 2020

No description provided.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 28, 2020
@claassistantio
Copy link

claassistantio commented Jan 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@citizen428
Copy link
Contributor

citizen428 commented Jan 28, 2020 •
edited
Loading

@swrobel Thanks for the contribution! 🎉 For future PRs, can you please use our PR template? I know it may seem like overkill for a small change like this, but we are reviewing lots of PRs and it does make it easier on our end. Thank you!

citizen428
citizen428 reviewed Jan 28, 2020
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
rhymes
rhymes reviewed Jan 28, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swrobel, thanks for the PR!

Left my 2c on this

Gemfile Outdated Show resolved Hide resolved
@swrobel
Copy link
Contributor Author

swrobel commented Jan 29, 2020

@citizen428 @rhymes requested changes have been made

rhymes
rhymes approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @swrobel!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 29, 2020
citizen428
citizen428 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @swrobel

@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
@maestromac maestromac merged commit 60a28f1 into forem:master Feb 3, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 3, 2020
This was referenced Feb 10, 2020
Closed
Merged
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
@rhymes rhymes mentioned this pull request Feb 11, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@rhymes rhymes rhymes approved these changes

@maestromac maestromac Awaiting requested review from maestromac

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swrobel @claassistantio @citizen428 @rhymes @maestromac