Fixed Storybook

[nickytonline]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

We'll be using Storybook for the design system, so I've resuscitated it. We're currently using a downgraded version (3.4.11) because we are currently using webpacker 3. Latest versions of Storybook have been on webpack 4 for quite some time now.

There is a bigger task of upgrading webpacker, so for now we will stay with this downgraded version of Storybook. See this Tweet thread.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

[nickytonline]

This PR looks like nothing... it is. However, I was scratching my head for a whole day why downgrading didn't work. I finally literally copied the entire package.json version from the last working Storybook in the repo and it still wasn't working. And then it clicked. I've had this issue before. I had to delete the yarn.lock file and completely regenerate it, to have the proper deps in the lock file. 🙃

[maestromac]

what a doozy

[nickytonline]

@maestromac @Zhao-Andy, no rush on this, but this means at some point we can revisit #338.

[nickytonline]

Although I have not changed any of the code for the application, the yarn.lock file had some severe modifications. I would assume all is good, given the build status, but I will do a smoke test in the AM.

[rhymes]

Let's go back in time to go forward in time!

I can't wait for us to switch to webpack 4, it'll unlock many superpowers (babel 7, new storybook, various packages that can be upgraded and last but not least, it'll get us closer to Rails 6 which requires webpack 4).

[nickytonline]

I've done a smoke test and things appear to be good in the app.