Return NotFound error if ChatChannelMembership is not found #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
reviewed
Jan 29, 2020
There was a problem hiding this comment.
Hi @majakomel, thanks for the PR!
Left a note about style, I think we should lean towards using Rails than custom code
Comment on lines
5
to
6
| @membership = ChatChannelMembership.where(chat_channel_id: params[:chat_channel_id], user_id: current_user.id).first | ||
| not_found unless @membership |
There was a problem hiding this comment.
Can I suggest replacing this with:
ChatChannelMembership.where(...).first!?
Rails has many handy ActiveRecord methods to bail out in case items don't exist, see https://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html#method-i-first-21
There was a problem hiding this comment.
Sure! not_found was suggested in the issue description and I just went with it. It's replaced now :)
majakomel
force-pushed
the
chat-channel-membership-fix
branch
from
8abbb4d
to
62ee693
Compare
pr-triage
bot
added
PR: reviewed-approved
mstruve
approved these changes
Feb 5, 2020
| @@ -2,7 +2,7 @@ class ChatChannelMembershipsController < ApplicationController | |||
| after_action :verify_authorized | |||
|
|
|||
| def find_by_chat_channel_id | |||
| @membership = ChatChannelMembership.where(chat_channel_id: params[:chat_channel_id], user_id: current_user.id).first | |||
| @membership = ChatChannelMembership.where(chat_channel_id: params[:chat_channel_id], user_id: current_user.id).first! | |||
There was a problem hiding this comment.
TIL you can put a bang on first!
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Returns
ActiveRecord::RecordNotFoundinstead ofPundit::NotDefinedErrorwhen chat channel membership is not found.Related Tickets & Documents
Fixes #5790
Added to documentation?