Update yarn.lock

[rhymes]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

I ran yarn install --dev on master as I often do on each breanch when switching for PR reviews and I noticed this time it updated the lock file, which makes me suspect it wasn't updated correctly in a previous PR.

Try to do the same on your local master and see if the yarn.lock gets updated locally

[citizen428]

I noticed this yesterday too, but then forgot about it as I was deep in my (backend) PR and config.webpacker.check_yarn_integrity = true in development.rb was a good enough temp fix for me.

But I agree, we should probably update this file, as it seems it wasn't checked in last time packages were updated.

[nickytonline]

I had changes to yarn.lock the other day in regards to fixing Storybook (#5783), but made sure it updated correctly. Just ensure with these changes that you can still view Storybook (npm run storybook, then navigate to http://localhost:6006)

[rhymes]

@citizen428 I actually thought it was always true in development! @nickytonline, is there a reason to keep the yarn integrity check disabled in development?

@nickytonline:

Just ensure with these changes that you can still view Storybook (npm run storybook, then navigate to http://localhost:6006

You mean yarn storybook ;-) ? Yeah, it works:

➜  devto git:(rhymes/update-yarn-lockfile) yarn storybook
yarn run v1.21.1
$ start-storybook -p 6006 -c app/javascript/.storybook -s app/javascript/.storybook/assets
info @storybook/react v3.4.11
info
info => Loading static files from: /Users/rhymes/Development/devto/app/javascript/.storybook/assets .
info => Loading custom .babelrc
info => Loading custom addons config.
info => Loading custom webpack config (full-control mode).
webpack built 1f85e6ae6f8d02aec3e9 in 22575ms
info Storybook started on => http://localhost:6006/
info

[nickytonline]

@nickytonline, is there a reason to keep the yarn integrity check disabled in development?

@rhymes, I have more experience with npm over yarn, but to me it makes sense to have it enabled all the time.

[rhymes]

I traced the optional check for integrity to this PR:

#296

see this discussion #296 (review)

Basically we can't enable it by default, because it's broken under docker: rails/webpacker#1568

I'm going to add a note in development.rb about it

[citizen428]

👍 for inlining this.

[nickytonline]