Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a core team member #5812

Merged
merged 1 commit into from
Feb 3, 2020
Merged

chore: add a core team member #5812

merged 1 commit into from
Feb 3, 2020

Conversation

Ridhwana
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adding Ridhwana as a core team contributor

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

giphy (35)

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 29, 2020
@claassistantio
Copy link

claassistantio commented Jan 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

benhalpern
benhalpern approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 29, 2020
rhymes
rhymes approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
@Ridhwana Ridhwana removed the request for review from maestromac February 3, 2020 15:36
@maestromac maestromac merged commit 6b53331 into forem:master Feb 3, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
@Ridhwana Ridhwana deleted the Ridhwana/add-core-team-member branch February 24, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ridhwana @claassistantio @rhymes @benhalpern @maestromac