Return 404 NotFound error if @moderatable Is Not Found instead of failing with 500 #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhymes Hey, could you also review this PR |
|
Hi @Zeko369, sorry for the late reply, I think before accepting this we should find a way to add a test for it, what do you think? |
|
There are no tests for #article and #comment. Should I create a separate PR for adding those specs @rhymes ? |
|
@Zeko369, it'd be great if you could add a spec related to this change in this PR! :-) Thank you! |
mstruve
previously approved these changes
Feb 6, 2020
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: unreviewed
|
Fixed via #5999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
closes #5791
Description
Return 404 for not found when @moderatable is not found, instead of failing with 500 when calling id on it later
What gif best describes this PR or how it makes you feel?
When you fix a bug just by adding "!", tnx DHH