Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer in shecoded rendered twice #5823

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Footer in shecoded rendered twice #5823

merged 1 commit into from
Feb 3, 2020

Conversation

abdellani
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fixes #5741

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screenshot_2020-01-31 #SheCoded 👩🏿‍💻👩‍💻👩🏾‍💻 - DEV Community
After the update :
Screenshot_2020-01-31 #SheCoded 👩🏿‍💻👩‍💻👩🏾‍💻 - DEV Community1

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

benhalpern
benhalpern approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We're probably going to change more things as we look back at this, but may as well merge this for now!

@citizen428 citizen428 self-requested a review February 3, 2020 06:47
citizen428
citizen428 reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rremember to emove the [WIP] tag when you're done with this PR.

@abdellani abdellani changed the title [WIP] Footer in shecoded rendered twice Footer in shecoded rendered twice Feb 3, 2020
@pr-triage pr-triage bot added the PR: reviewed-approved bot applied label for PR's where reviewer approves changes label Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
maestromac
maestromac approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maestromac maestromac merged commit 058f6a2 into forem:master Feb 3, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 left review comments

@benhalpern benhalpern benhalpern approved these changes

@maestromac maestromac maestromac approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer in shecoded rendered twice
4 participants
@abdellani @citizen428 @benhalpern @maestromac