-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move edit and delete buttons on chat messages to dropdown menu #5828
Move edit and delete buttons on chat messages to dropdown menu #5828
Conversation
63fa50f
to
55b0647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bolariin Thanks for your effort 😊. I have added few comments, please take a look. Feel free to ask if got stuck. 😉
Looks great to me. I haven't had the chance to do a full review, but the gif looks good. |
Hi @bolariin! It looks like our team majorly dropped the ball on getting back to you on this PR. I am terribly sorry about that. We value your time and effort and certainly don't ever want this to happen. With that said, we are in the process of going through and cleaning up some of our PR history to help us better prioritize what we need to be focusing on. Since this PR has not been active for a while and has a few conflicts I am going to go ahead and close it for now. If you would still like to get this merged please feel free to resolve the conflicts and then open the PR back up. We would be more than happy to help you push this through if you would like! We also have a much larger team now so we can ensure it gets the attention it needs. Thank you so much for contributing! Ping us anytime if you have questions! |
New PR opened on #7820 |
What type of PR is this? (check all applicable)
Description
This PR moves the edit and delete buttons that are revealed when you hover on message into a dropdown menu. I also added the shortcut to delete the last message. I used the up arrow key for the shortcut.
Related Tickets & Documents
Resolves #5222
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?