pass command line args to wkhtmltopdf to enable better formatting #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2018
craig-davis
requested changes
Oct 19, 2018
There was a problem hiding this comment.
Thanks for this change, this looks like a nice addition to have!
I hope you're getting some Hacktoberfest credit for it!
src/Resume/Command/PdfCommand.php
Outdated
| @@ -82,11 +104,24 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| // Save to a temp destination for the pdf renderer to use | |||
| file_put_contents($pdfSource, $rendered); | |||
|
|
|||
| $cmd = "wkhtmltopdf $pdfargs $pdfSource $destFilename"; | |||
| // $output->writeln($cmd); | |||
There was a problem hiding this comment.
Suggested change
| // $output->writeln($cmd); |
Was this commented out line left over from debugging? If so, can we please remove it?
|
Removed unnecessary comment. Wasn't aware of Hacktoberfest -- thanks for mentioning it! |
craig-davis
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 options to
PdfCommand:wkhtmltopdfinstead of removing it. This is useful for debugging (e.g. CSS issues that aren't transparent when only viewing the final PDF).wkhtmltopdfwhich enables better control of PDF generation (e.g. margins, media type).