v2 release - Country rebuild - ISOs missing, countries not accurate #19
Comments
|
There were a few different sources I pulled from, one from this super old php script I found, another from an open API that I queried. There are gaps in them for sure, but sadly those would need to be corrected manually. |
|
popsicles. in the interim then, i can manually populate the missing ones, and then when there's some free time for myself this week, I can perhaps make a small node script to pull down and re-generate the json files. thanks! |
|
Thanks for your help with this. Been less active on my OSS projects as I would like to be, hoping to change that this week. If you've got a lot of stuff you'd like to play with, and if you're interested, I could give you contrib access to this project. I'll double check with the other Growmies of course, but your work so far has been pretty solid. |
|
Also, PR merged, lemme know if/when you have a rebuild script for the data. I'll also try to track down the original build script I used. |
|
for sure. i'm trying to be more active myself and not be so lazy i'd be more than interested to continue contributing! 👍 i started working on a node script for it and am creating a list of good sources to grab each data point from. i technically could just scrape wikipedia, but i'll tack that onto my list for now and find the fewest sources to get all the data that's already present.
|
|
I had found a country API through Mashape that was good for most of them (probably where I got the Yugoslavia issue from), and I had made a looping scraper off that for most of it. The states... I'm trying to remember. I think that one was the PHP script. I'll look into it further. I'm heading over to the Grow HQ today, I'll ask about getting you added as a fully permissioned contrib. In the meantime, I added you to the package.json and the README :) So if nothing else you get the illustrious fame for working on this ;) #stealingyourgif |
therebelrobot
changed the title
|
I've come to realize how nutty ISO 3166 is 😲 awesomesauce! I've been enjoying trying to be more contributory (this actually is a word). I was sitting around trying to pick something to contribute to, but realizing that it was more natural contributing to something I'm actually using. that's the point then I suppose :P I feel like David Bowie now. Thanks 😍 |
|
Lol. Got the LGTM from @hillmanov, added you to the open source group with Growmies, which should give you push access to this repo. I'm still looking through your bulkify change and will merge that once I've done more testing, but if you want to make contributions in the future, just open a new branch on this and when you're ready, PR it in. :) Thanks again for your help. |
|
great, will do! anytime; thanks for allowing me to! 😻 i haven't seen many lgtm gifs. i have a growing directory of reaction gifs. my absolute favorite out of all of them though... which I find hilarious, but not many people might?
|
|
Lol. love it 👍 |
|
@therebelrobot i'm not dead :) just been busy with worky-work. found this: and I started working on a scraper for an alternative source. will repurpose it for fetch this. |
|
Not to worry, @moimikey. We've all got day jobs, and unless we get a company who is invested in this to pay for our work on it, we'll both be hitting it in our free time. That repo looks spectacular! Definitely a good resource. If there is somewhere you want help on this, lemme know, I can hop in and assist. I appreciate your interest in this though. This is how open source soars :D |
|
true true yeah, it seems like an extremely up to date resource. since they offer so much, we can just takeaway the bits that will promote non-breaking change. and yes, totally. open source is beneficial to everyone including yourself. |
|
@therebelrobot so here is my initial attempt so far. there's a couple of data issues that i'll just need to address. i may want go re-write this in es7 so i can get async/await which would be nice... especially for the multiple sources (which is where the initial data trouble is) https://gist.github.com/moimikey/7740ae6827045021411b
let me know your thoughts! |
|
I love the script. It seems to be pretty solid (and informed me of some modules I've never seen before and am excited to try out). Did you run the output code through tests? As for province list and time zones, I'll do some digging this week and see if I can't find a good resource for finding those. |
|
at the moment it just outputs it in a single json, but i can tweak it to output it into each individual json and then will run it through the tests and get back to ya :D i've been getting obsessed with streams! |
|
Hey @moimikey what's the status on your work with this? Growmies just transferred full ownership of this repo to me, so I wanted to get a better handle on what the status was on open issues. |
|
@therebelrobot hey you :) i can issue a PR tonight with the generator script. i ended up completing it. |
|
Coolcool. Let me know when you want me to review it, and I'll hop right in. |
|
fer sure! i started revising it again. here's the checklist of what I need to finish for data points:
for population, do you feel that it's a bit ambiguous to have a number set, but there isn't any information regarding at what point in time that population was valid? is it worth 86ing this? or should it be expanded and instead of being a but that would just infinitely grow. thoughts?
!/usr/bin/env node
var hyperquest = require('hyperquest')
var through2 = require('through2')
hyperquest('https://raw.githubusercontent.com/tamaspiros/world/master/data/unitedstates.json')
.pipe(through2.obj(function(chunk, enc, cb) {
var data = JSON.parse(chunk)
this.push({
name: data.name.common,
altSpellings: data.altSpellings,
area: data.area,
borders: data.borders,
callingCodes: data.callingCode,
capital: data.capital,
currencies: Array,
demonym: data.demonym,
flag: String,
geoJSON: Object,
ISO: {
alpha2: data.cca2,
alpha3: data.cca3,
},
languages: Array, /* languages: { eng: 'English' } ---> to array? different data source? */
latlng: data.latlng,
nativeName: String,
population: Number,
provinces: Array,
region: data.region,
subregion: data.subregion,
timezones: Array,
tld: data.tld,
translations: Object,
wiki: String
})
cb()
}))
.on('data', function(data) {
console.log(data)
}) |
IMO, the more exact the data, the better. If you have the years/populations, let's make an API change and add those in. |
|
Hey @moimikey, I'm gonna take a look today at trying to push out a release for this. Sorry for being AWOL for so long myself, been working on moving to california. I'm gonna start with the code you listed above for building the objects, and I'll place the build script into the |
|
All good Trent! I'm on a cruise for the next week. Got a local branch I have yet Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.2] I'm gonna start with the code you listed above for building the objects, and — |
|
So I ended up pushing the initial work into |
|
So for this next release, I want to add in state short codes, where available. Refer #28. Here's a link to the list linked there: http://www.unece.org/cefact/codesfortrade/codes_index.html |
|
@therebelrobot any progress with state short codes? Need help? |
|
Hey @tamagokun! I'd love additional help on this, for sure! I also wanted to wrap in the API change for #35 as well (return all results in an array), but haven't slowed down enough to get it done. If you have the bandwidth, I'd be happy to add you as a collaborator to work on it (so long as you work in feature branches/PRs, I'm kind of particular about release flow). Once you have something to take a look at, I'd be happy to review. If you don't that's fine, with my current bandwidth I'll be looking at the next couple weeks to circle back on this myself. |
therebelrobot
changed the title
|
On second thought, I'm actually pretty close to getting this rolling. I'll work on it over the next few days, and see about getting a v2 out this weekend. |
|
@therebelrobot Impressive works going on for the V2! Do you need some help to get it finished? Do you have an ETA in mind? |
|
Hi @therebelrobot! I found this thread and saw that you were in progress adding state/province short codes—is there anything I can do to help get that, and/or v2 over the finish line? |
|
As of now I believe CountryJS release v2 is on permanent hold, we are in
maintenance mode. I can add you as a collab if you would like to work on
v2, but @therebelrobot is no longer working on this project.
…--
[image: Giftnix]
Brandon Copley
Founder & CEO
t: 512.784.6060 <(512)%20784-6060>
e: copley.brandon@gmail.com
On Fri, Apr 14, 2017 at 2:07 PM, Chris Forrette ***@***.***> wrote:
Hi @therebelrobot <https://github.com/therebelrobot>! I found this thread
and saw that you were in progress adding state/province short codes—is
there anything I can do to help get that, and/or v2 over the finish line?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJShi-77ORvkJcIQygZaluHzoTB3JKNks5rv8QBgaJpZM4D_qif>
.
|
|
@BrandonCopley I would love to be a contributor. If it's on permanent hold, is there someone reviewing PRs? and/or someone who I can work with to make sure work is in-line with what was already in progress? |
|
So far thats me, I brought the project up to date a few months ago, and
just try to maintain.
If you want to help add the first PR and I'll be active with merging, etc.
I don't have any idea where v2 status is though. We may have to restart it
from scratch. I have done no v2 work whatsoever.
On Mon, Apr 17, 2017 at 7:00 PM Chris Forrette ***@***.***> wrote:
@BrandonCopley <https://github.com/BrandonCopley> I would love to be a
contributor.
If it's on permanent hold, is there someone reviewing PRs? and/or someone
who I can work with to make sure work is in-line with what was already in
progress?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJShhcdtYSfbRwRhiLybtD-sjsnR8eGks5rw_0wgaJpZM4D_qif>
.
--
--
[image: Giftnix]
Brandon Copley
Founder & CEO
t: 512.784.6060 <javascript:void(0);>
e: copley.brandon@gmail.com
|
|
Hello @therebelrobot / @BrandonCopley / @chrisforrette / @moimikey , I would love to be a contributor to help on v2. Also, I would like to add some missing ISO information as well. |
|
Feel Free to add ISO information in a pull request currently no plans for
v2 exist.
…--
[image: Giftnix]
Brandon Copley
Founder & CEO
t: 512.784.6060 <(512)%20784-6060>
e: copley.brandon@gmail.com
On Tue, Jan 2, 2018 at 2:30 PM, Jorge L Ulloa Velazquez < ***@***.***> wrote:
Hello @therebelrobot <https://github.com/therebelrobot> / @BrandonCopley
<https://github.com/brandoncopley> / @chrisforrette
<https://github.com/chrisforrette> / @moimikey
<https://github.com/moimikey> , I would love to be a contributor to help
on v2. Also, I would like to add some missing ISO information as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJShhwAhmkGTyIFKAxfYLct9alclJEcks5tGpH0gaJpZM4D_qif>
.
|
|
I already created the PR(GH-61). I'm getting up to speed with V2. It looks like it almost done based on the above comments. I definitely want to keep this going. |
|
Sounds good, let's get some work and PR's and I'll look at and can add you
as a contributor here. thanks!
…--
[image: Giftnix]
Brandon Copley
Founder & CEO
t: 512.784.6060 <(512)%20784-6060>
e: copley.brandon@gmail.com
On Thu, Jan 4, 2018 at 10:57 AM, Jorge L Ulloa Velazquez < ***@***.***> wrote:
I already created the PR(GH-61
<#61>).
I'm getting up to speed with V2. It looks like it almost done based on the
above comments. I definitely want to keep this going.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJShjGSedhO-fcIx1J7No32HixvZWiEks5tHQLngaJpZM4D_qif>
.
|
there's a lot of undefined ISOs. Some of which actually do have ISO codes like U.S. Virgin Islands which has an ISO3 of
VIR. out of curiosity, i'm sure you generate these somehow?The text was updated successfully, but these errors were encountered: