This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
add delete method for activities & fix testing stub #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing stub did not create IDs for notes and calls and therefore did not return the correct result as the API would do. This is a BREAKING CHANGE for testing. The methods get_activity_call and get_activity_note will return a different response in tests.
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 41.34% 41.06% -0.28%
==========================================
Files 9 9
Lines 786 823 +37
==========================================
+ Hits 325 338 +13
- Misses 461 485 +24
Continue to review full report at Codecov.
|
anneFly
force-pushed
the
activity-delete
branch
from
c314556
to
c65b810
Compare
anapaulagomes
approved these changes
Nov 8, 2018
| @@ -286,14 +287,50 @@ def create_activity_call(self, **kwargs): | |||
| calls[lead_id].append(call) | |||
|
|
|||
| @parse_response | |||
| def create_activity_note(self, lead_id, note): | |||
| def create_activity_note(self, **kwargs): | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds delete methods for all activities:
delete_activity_emaildelete_activity_calldelete_activity_noteFurthermore, this fixes the testing stub. The methods
get_activity_callandget_activity_notedid not return records with IDs.Note: this PR should most likely be merged keeping separate commits.