Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format space keystroke #192

Merged
merged 3 commits into from
Jun 24, 2016
Merged

Format space keystroke #192

merged 3 commits into from
Jun 24, 2016

Conversation

mpsijm
Copy link
Collaborator

@mpsijm mpsijm commented Jun 23, 2016

In the RestAPIDatabaseAdapter, " " is now rewritten to "Space" to avoid 400 errors. I asked @aaronang about this and he approves this change.

Have fun reviewing, it's not much :)

@mpsijm mpsijm added the review label Jun 23, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 91.686% when pulling 6be203f on _-format-space-keystroke into e9e8326 on dev.

@Exclaminator
Copy link
Collaborator

Please add a test for this.

Met vriendelijke groet,
Youri Arkesteijn

On Thu, Jun 23, 2016 at 4:56 PM, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/6724295

Coverage decreased (-0.04%) to 91.686% when pulling _6be203f
6be203f
on -format-space-keystroke into e9e8326
e9e8326
on dev
.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#192 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAdBI7Tbqbp4QVEDpkjtl2r4gQatwWgQks5qOp6cgaJpZM4I85V-
.

@mpsijm
Copy link
Collaborator Author

mpsijm commented Jun 23, 2016

@Exclaminator I wrote a test, thanks for noticing :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.761% when pulling 928b973 on _-format-space-keystroke into e9e8326 on dev.

@mdingjan
Copy link
Collaborator

Logging a space works nicely. :)
Thanks for adding the extra test.

Ready for merging!

@thervh70
Copy link
Owner

Looking very good. No more debugging errors!
Will merge.

@thervh70 thervh70 merged commit 7556020 into dev Jun 24, 2016
@thervh70 thervh70 deleted the _-format-space-keystroke branch June 24, 2016 07:58
@thervh70 thervh70 removed the review label Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants